Fix long durations being emitted because of state ltt by frank-spano · Pull Request #54074 · DataDog/datadog-agent

frank-spano · 2026-07-23T20:34:20Z

What does this PR do?

Fixes the case where ongoing_rollout_duration would emit large values, because it was using a stale LastTransitionTime to calculate the rollout duration.

Motivation

https://dd.slack.com/archives/C4TQDFK1P/p1784821818195809

Describe how you validated your changes

Additional Notes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 652476de17

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-23T20:38:13Z

-					return cond.LastTransitionTime.Time
+			if cond.Status == corev1.ConditionTrue && isInProgressRolloutReason(cond.Reason) {
+				lastTransition := cond.LastTransitionTime.Time
+				if !lastTransition.IsZero() && time.Since(lastTransition) <= maxPlausibleRolloutDuration {


Avoid capping legitimate rollout durations at 24h

When the tracker starts fresh during a rollout that has genuinely been progressing for more than 24 hours, the newest ReplicaSet is also older than RecentCreationThreshold, so this check rejects Kubernetes' only persisted start time and falls back to now. In that scenario deployment.rollout_duration drops from days to seconds after an Agent restart, which hides exactly the long-running rollouts this metric is meant to surface; please avoid a hard 24h cutoff or validate staleness against revision/ReplicaSet state instead.

Useful? React with 👍 / 👎.

datadog-official · 2026-07-23T20:54:29Z

🎯 Code Coverage (details)
• Patch Coverage: 78.95%
• Overall Coverage: 52.07% (+0.14%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 67c1648 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-07-23T21:32:35Z

Files inventory check summary

File checks results against ancestor 6332ce3d:

Results for datadog-agent_7.83.0~devel.git.362.67c1648.pipeline.127135361-1_amd64.deb:

No change detected

dd-octo-sts · 2026-07-23T21:38:23Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6332ce3
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+5.96 KiB (0.00% increase, -0.09% of buffer)	751.783 → 751.789 → 758.200
✅	agent_rpm_amd64	+5.96 KiB (0.00% increase, -0.09% of buffer)	751.767 → 751.772 → 758.170
✅	agent_suse_amd64	+5.96 KiB (0.00% increase, -0.09% of buffer)	751.767 → 751.772 → 758.170
✅	docker_agent_amd64	+12.55 KiB (0.00% increase, -0.37% of buffer)	810.448 → 810.460 → 813.790
✅	docker_agent_arm64	+7.18 KiB (0.00% increase, -0.24% of buffer)	812.118 → 812.125 → 815.030
✅	docker_agent_jmx_amd64	+12.55 KiB (0.00% increase, -0.38% of buffer)	1001.345 → 1001.357 → 1004.550
✅	docker_agent_jmx_arm64	+7.17 KiB (0.00% increase, -0.23% of buffer)	991.668 → 991.675 → 994.710
✅	docker_host_profiler_amd64	+13.03 KiB (0.00% increase, -0.10% of buffer)	304.993 → 305.005 → 317.640
✅	docker_host_profiler_arm64	+13.07 KiB (0.00% increase, -0.10% of buffer)	316.318 → 316.331 → 328.900

23 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64_fips	706.565 MiB
✅	agent_heroku_amd64	308.029 MiB
✅	agent_rpm_amd64_fips	706.549 MiB
✅	agent_rpm_arm64	728.390 MiB
✅	agent_rpm_arm64_fips	686.313 MiB
✅	agent_suse_amd64_fips	706.549 MiB
✅	agent_suse_arm64	728.390 MiB
✅	agent_suse_arm64_fips	686.313 MiB
✅	docker_cluster_agent_amd64	209.866 MiB
✅	docker_cluster_agent_arm64	222.953 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.243 MiB
✅	docker_dogstatsd_arm64	37.368 MiB
✅	dogstatsd_deb_amd64	29.984 MiB
✅	dogstatsd_deb_arm64	28.024 MiB
✅	dogstatsd_rpm_amd64	29.984 MiB
✅	dogstatsd_suse_amd64	29.984 MiB
✅	iot_agent_deb_amd64	46.153 MiB
✅	iot_agent_deb_arm64	42.845 MiB
✅	iot_agent_deb_armhf	43.613 MiB
✅	iot_agent_rpm_amd64	46.154 MiB
✅	iot_agent_suse_amd64	46.153 MiB

cit-pr-commenter-54b7da · 2026-07-23T22:01:00Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 841b2384-3963-4843-91ae-acac8e12f8ce

Baseline: 77ee64f
Comparison: eb4c9f9
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.53	[-0.48, +1.54]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.20	[+0.11, +0.29]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.13	[+0.09, +0.17]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.00	[-0.12, +0.12]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.02	[-0.07, +0.04]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.10	[-0.15, -0.04]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.20	[-0.23, -0.16]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.69	[-0.93, -0.45]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	148.82MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	730.32KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	490.71MiB ≤ 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	189.07MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.18MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	374.48 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	397.56MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.08MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	29.20 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	300.91MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	63.33 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	279.70MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.72 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	288.41MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_mean_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

…2528.yaml Co-authored-by: Alexandre Lavigne <alexandre.lavigne@datadoghq.com>

frank-spano · 2026-07-27T13:00:18Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-27T13:00:22Z

View all feedbacks in Devflow UI.

2026-07-27 13:00:21 UTC ℹ️ Start processing command /merge

2026-07-27 13:00:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-07-27 14:35:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-07-27 15:51:24 UTC ℹ️ MergeQueue: This merge request was merged

### What does this PR do? Fixes the case where ongoing_rollout_duration would emit large values, because it was using a stale LastTransitionTime to calculate the rollout duration. ### Motivation https://dd.slack.com/archives/C4TQDFK1P/p1784821818195809 ### Describe how you validated your changes ### Additional Notes Co-authored-by: frank.spano <frank.spano@datadoghq.com>

Fix long durations being emitted because of state ltt

652476d

frank-spano requested a review from a team as a code owner July 23, 2026 20:34

dd-octo-sts Bot added internal Identify a non-fork PR team/container-integrations labels Jul 23, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 23, 2026

reno

f69d160

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jul 23, 2026

Fix codex found bug for legit long rollouts

e0bf5e1

frank-spano added the qa/done QA done before merge and regressions are covered by tests label Jul 23, 2026

lavigne958 reviewed Jul 27, 2026

View reviewed changes

Comment thread releasenotes/notes/fix-ongoing-rollout-transition-9ac44f31a3ce2528.yaml Outdated

Update releasenotes/notes/fix-ongoing-rollout-transition-9ac44f31a3ce…

67c1648

…2528.yaml Co-authored-by: Alexandre Lavigne <alexandre.lavigne@datadoghq.com>

lavigne958 approved these changes Jul 27, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit eb4c9f9 into main Jul 27, 2026
276 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the frank.spano-roll-dur-fix branch July 27, 2026 15:51

github-actions Bot added this to the 7.83.0 milestone Jul 27, 2026

Navigation Menu

Uh oh!

Fix long durations being emitted because of state ltt - #54074

Fix long durations being emitted because of state ltt#54074
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
frank.spano-roll-dur-fix

frank-spano commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 23, 2026

Uh oh!

frank-spano Jul 23, 2026

Uh oh!

datadog-official Bot commented Jul 23, 2026 •

edited by datadog-datadog-us1-prod Bot

Loading

Uh oh!

dd-octo-sts Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Jul 23, 2026 •

edited

Loading

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Jul 23, 2026 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Profiling Replicate Execution Failures (ddprof)

Uh oh!

Uh oh!

frank-spano commented Jul 27, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

frank-spano commented Jul 23, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

frank-spano Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-official Bot commented Jul 23, 2026 • edited by datadog-datadog-us1-prod Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.83.0~devel.git.362.67c1648.pipeline.127135361-1_amd64.deb:

Uh oh!

dd-octo-sts Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Profiling Replicate Execution Failures (ddprof)

CI Pass/Fail Decision

Uh oh!

Uh oh!

frank-spano commented Jul 27, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

datadog-official Bot commented Jul 23, 2026 •

edited by datadog-datadog-us1-prod Bot

Loading

dd-octo-sts Bot commented Jul 23, 2026 •

edited

Loading

dd-octo-sts Bot commented Jul 23, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Jul 23, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 •

edited

Loading